BEGIN

BEGIN TRY
	DECLARE @contactid uniqueidentifier
	DECLARE @companyname varchar
	DECLARE @historytypeid int
	DECLARE @endtime datetime
	DECLARE @duration int
	DECLARE @subject varchar
	DECLARE @ttyperid bigint
	DECLARE @rid bigint
	DECLARE @title varchar(100)
	DECLARE @tasktypeid int
	DECLARE @flag bigint
	SET @flag = 0

	DECLARE cur cursor STATIC LOCAL 
	FOR
		SELECT 	tc.contactid,tc.companyname, 
			th.historytypeid,
			th.endtime,
			th.duration,
			th.regarding,
			tht.name 
		FROM 	tp.dbo.tbl_contact tc
			JOIN tp.dbo.tbl_contact_history tch 	ON tc.contactid = tch.contactid
			JOIN tp.dbo.tbl_history th 		ON th.historyid = tch.historyid
			JOIN tp.dbo.tbl_historytype tht 	ON tht.historytypeid = th.historytypeid 
		WHERE 	category IS NOT NULL 
		AND 	th.historytypeid<>-1

	OPEN cur
	FETCH cur INTO @contactid,@companyname,@historytypeid,@endtime,@duration,@subject,@title

	print @contactid
	print @companyname
	print @historytypeid
	print @endtime
	print @duration
	print @subject
	print @title

	print 'cur fetched'
	
	WHILE @@fetch_status = 0
	BEGIN
		BEGIN
			BEGIN TRANSACTION
			
			SET @rid = 0
			SELECT 	@rid = MAX(rid) 
			FROM 	hc_clients 
			WHERE 	clientname = @companyname
			
			print @rid
			SET @tasktypeid = 0
			SELECT @tasktypeid = MAX(rid) FROM hcm_task_type WHERE title = @title
			
			IF 	@tasktypeid IS NULL
			BEGIN
				INSERT INTO hcm_task_type(title) VALUES(@title)
				SELECT @tasktypeid = MAX(rid) FROM hcm_task_type WHERE title = @title AND @title IS NOT NULL
			END

			SET @flag = @flag + 1
			print @flag
			
			INSERT INTO hc_task_manager(tasktype,targetdate,reminder,duration,subject,status,tasktypeid,ttyperid,remindercheck)
			VALUES (@tasktypeid,@endtime,0,@duration,@subject,0,1,@rid,0)
		END

		COMMIT TRANSACTION
	END

	FETCH cur INTO @contactid,@companyname,@historytypeid,@endtime,@duration,@subject,@title
	CLOSE cur
	DEALLOCATE cur
	-- print @flag
END TRY

BEGIN CATCH
	print 'Error'
	ROLLBACK TRANSACTION
END CATCH

END 

quote:

---

Originally posted by khtan

if you do format your code, you will see that your FETCH is outside of the cursor while loop.

---

KH
[spoiler]Time is always against us[/spoiler]

---